Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When displaying ENV values in GitHub Checks, escape less #187

Merged
merged 2 commits into from Sep 5, 2019
Merged

When displaying ENV values in GitHub Checks, escape less #187

merged 2 commits into from Sep 5, 2019

Conversation

BanzaiMan
Copy link
Contributor

@BanzaiMan BanzaiMan commented Sep 5, 2019 •
edited

svenfuchs
svenfuchs approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@svenfuchs svenfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

BanzaiMan
BanzaiMan commented Sep 5, 2019
View reviewed changes
spec/addons/github_check_status/output_spec.rb
{
"rvm": [
"1.8.7",
"1.9.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this display part is slightly off because of the example payload (which is not quite consistent; I chose brevity in spec payload)

@BanzaiMan BanzaiMan merged commit e00b517 into master Sep 5, 2019
@BanzaiMan BanzaiMan deleted the ha-gh-checks-env-display branch September 5, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenfuchs svenfuchs svenfuchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BanzaiMan @svenfuchs