Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember dependencies to 3.7.* #1920

Merged
merged 43 commits into from
Jan 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
c383821
chore(package): update ember-source to version 3.6.0
greenkeeper[bot] Dec 7, 2018
4dc86a6
chore(package): update lockfile package-lock.json
greenkeeper[bot] Dec 7, 2018
50448a2
Change uses of Ember.merge to Ember.assign
backspace Dec 7, 2018
5aea7e5
Update ember-svg-jar
backspace Dec 7, 2018
40bf52a
Remove accesses to transition parameters
backspace Dec 10, 2018
7b90f24
Convert didTransition to routeDidChange
backspace Dec 10, 2018
aaceeef
Remove use of Sinon
backspace Dec 10, 2018
ee83d9d
Add missing router injections
backspace Dec 10, 2018
71ecdd8
Update ember-intercom-io
backspace Dec 10, 2018
b3eaa6c
Change dependencies to fix build
backspace Dec 10, 2018
a738fe1
Merge branch 'master' of github.com:travis-ci/travis-web into greenke…
backspace Dec 11, 2018
59acc64
Change to older ember-intercom-io
backspace Dec 11, 2018
faa7ad7
Update to 1.1.5 again…???
backspace Dec 11, 2018
c0d4f78
Merge branch 'master' into greenkeeper/ember-source-3.6.0
backspace Dec 11, 2018
a58aeaf
Merge branch 'master' into greenkeeper/ember-source-3.6.0
backspace Dec 12, 2018
8dfd08f
Update ember-cli etc
backspace Dec 12, 2018
bda8520
Remove troublesome build configuration line
backspace Dec 12, 2018
5b8912c
Update ember-test-selectors
backspace Dec 12, 2018
0385ebc
Remove unnecessary addon
backspace Dec 12, 2018
5b65fc1
Remove Babel regenerator configuration
backspace Dec 12, 2018
573d15b
Merge branch 'master' into greenkeeper/ember-source-3.6.0
backspace Dec 18, 2018
e496e2e
Add guard against missing observer
backspace Dec 18, 2018
34db7cd
Remove guard by changing from function to string
backspace Dec 18, 2018
def3abf
Update to Ember 3.6.1
backspace Dec 19, 2018
32c2b66
Update Ember to 3.6.1
backspace Jan 7, 2019
340d086
Change to master for ember-intercom-io
backspace Jan 8, 2019
7e0f584
Merge branch 'master' into greenkeeper/ember-source-3.6.0
backspace Jan 8, 2019
2ad824d
Replace ember-data section of lockfile
backspace Jan 8, 2019
bdfd1b2
Revert to older ember-cli-babel
backspace Jan 9, 2019
f110369
Update Ember dependencies to 3.7
backspace Jan 9, 2019
db9dcba
Update ember-cli-clipboard
backspace Jan 9, 2019
330428d
Revert to released version of ember-intercom-io
backspace Jan 9, 2019
0df6625
Update ember-prism
backspace Jan 9, 2019
50e7902
Return to newer ember-cli-babel
backspace Jan 9, 2019
33a6e86
Update to beta ember-cli-babel version
backspace Jan 9, 2019
4bea7bc
Update Ember CLI
backspace Jan 11, 2019
95545c0
Change to fork of ember-intercom-io
backspace Jan 14, 2019
c578fa8
Update ember-load-initializers
backspace Jan 14, 2019
83c6604
Merge branch 'master' into greenkeeper/ember-source-3.6.0
backspace Jan 15, 2019
e03fb4d
Update ember-cli-sentry
backspace Jan 15, 2019
e392293
Update ember-intercom-io to newest release
backspace Jan 24, 2019
a591442
Update ember-cli-babel
backspace Jan 24, 2019
b8048ff
Change output path for emoji
backspace Jan 25, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ module.exports = {
// node files
{
files: [
'.eslintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'testem.js',
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
/node_modules/

# misc
/.env*
/.sass-cache
/connect.lock
/coverage/
Expand Down
4 changes: 2 additions & 2 deletions app/adapters/v3.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { merge } from '@ember/polyfills';
import { assign } from '@ember/polyfills';
import { underscore } from '@ember/string';
import { pluralize } from 'ember-inflector';
import { get } from '@ember/object';
Expand All @@ -23,7 +23,7 @@ export default RESTAdapter.extend({
ajaxOptions: function (url, type = 'GET', options) {
options = options || {};
options.data = options.data || {};
options.data = merge({}, options.data); // clone
options.data = assign({}, options.data); // clone

for (let key in options.data) {
let value = options.data[key];
Expand Down
8 changes: 0 additions & 8 deletions app/router.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,9 @@
/* global _gaq */
import EmberRouter from '@ember/routing/router';
import config from './config/environment';

const Router = EmberRouter.extend({
location: config.locationType,
rootURL: config.rootURL,

didTransition() {
this._super(...arguments);
if (config.gaCode) {
_gaq.push(['_trackPageview', location.pathname]);
}
}
});

Router.map(function () {
Expand Down
10 changes: 9 additions & 1 deletion app/routes/application.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global Travis */
/* global Travis, _gaq */
import $ from 'jquery';

import TravisRoute from 'travis/routes/basic';
Expand All @@ -14,13 +14,21 @@ export default TravisRoute.extend(BuildFaviconMixin, KeyboardShortcuts, {
featureFlags: service(),
flashes: service(),
repositories: service(),
router: service(),

needsAuth: false,

init() {
this.get('auth').afterSignOut(() => {
this.afterSignOut();
});

this.router.on('routeDidChange', () => {
if (config.gaCode) {
_gaq.push(['_trackPageview', location.pathname]);
}
});

return this._super(...arguments);
},

Expand Down
7 changes: 2 additions & 5 deletions app/routes/basic.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,10 @@ export default Route.extend({
},

redirectToProfile(transition) {
// make this hack the least invasive it can be
let { targetName } = transition;
let { params } = transition;
let { owner } = this.paramsFor('owner');
if (targetName === 'owner.repositories' &&
params.owner &&
params.owner.owner &&
params.owner.owner === 'profile') {
owner === 'profile') {
this.transitionTo('account', {
queryParams: { offset: 0 }
});
Expand Down
5 changes: 3 additions & 2 deletions app/routes/first-sync.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,15 @@ export default SimpleLayoutRoute.extend({
activate() {
let controller;
controller = this.controllerFor('firstSync');
controller.addObserver('isSyncing', this, this.isSyncingDidChange);
controller.addObserver('isSyncing', this, 'isSyncingDidChange');
this.isSyncingDidChange();
},

deactivate() {
let controller;
controller = this.controllerFor('firstSync');
return controller.removeObserver('controller.isSyncing', this, this.isSyncingDidChange);

return controller.removeObserver('controller.isSyncing', this, 'isSyncingDidChange');
},

isSyncingDidChange() {
Expand Down
2 changes: 1 addition & 1 deletion app/routes/owner/repositories.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default TravisRoute.extend({
model({ page }, transition) {
const limit = config.pagination.profileReposPerPage;
const offset = (page - 1) * limit;
const owner = transition.params.owner.owner;
const owner = this.paramsFor('owner').owner;
const type = 'byOwner';
const sort_by = 'default_branch.last_build:desc'; // eslint-disable-line

Expand Down
2 changes: 1 addition & 1 deletion app/routes/owner/running.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default TravisRoute.extend({
model(params, transition) {
let includes =
'?include=user.repositories,organization.repositories,build.commit,repository.active';
let { owner } = transition.params.owner;
let { owner } = this.paramsFor('owner');
return $.ajax({
url: `${config.apiEndpoint}/owner/${owner}${includes}`,
headers: {
Expand Down
4 changes: 2 additions & 2 deletions app/routes/profile.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const SECTION_ROUTE_MAP = {
export default TravisRoute.extend({
accounts: service(),

beforeModel({ params, targetName }) {
const { section, login } = params[targetName] || {};
beforeModel({ targetName }) {
const { section, login } = this.paramsFor('profile') || {};
const isUserAccount = this.accounts.user.login === login;
const root = isUserAccount ? 'account' : 'organization';

Expand Down
4 changes: 2 additions & 2 deletions app/utils/fetch-all.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { merge } from '@ember/polyfills';
import { assign } from '@ember/polyfills';

let fetchAll = function (store, type, query) {
return store.query(type, query).then((collection) => {
let nextPage = collection.get('meta.pagination.next');
if (nextPage) {
let { limit, offset } = nextPage;
return fetchAll(store, type, merge(query, { limit, offset }));
return fetchAll(store, type, assign(query, { limit, offset }));
}
});
};
Expand Down
4 changes: 2 additions & 2 deletions app/utils/keys-map.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { merge } from '@ember/polyfills';
import { assign } from '@ember/polyfills';

let configKeys, configKeysMap, languageConfigKeys;

Expand Down Expand Up @@ -56,7 +56,7 @@ configKeys = {
os: 'OS'
};

configKeysMap = merge(configKeys, languageConfigKeys);
configKeysMap = assign(configKeys, languageConfigKeys);

export default configKeysMap;

Expand Down
5 changes: 1 addition & 4 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ module.exports = function () {
'ember-cli-babel': {
includePolyfill: true,
},
babel: {
blacklist: ['regenerator'],
},
fingerprint: fingerprint,
sourcemaps: {
enabled: true,
Expand Down Expand Up @@ -79,7 +76,7 @@ module.exports = function () {
});

const emojiAssets = new Funnel('node_modules/emoji-datasource-apple/img/apple/64', {
destDir: '/public/images/emoji'
destDir: '/images/emoji'
});

importNpmDependency(app, 'node_modules/fuzzysort/fuzzysort.js');
Expand Down
4 changes: 2 additions & 2 deletions mirage/serializers/feature.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Serializer } from 'ember-cli-mirage';
import { isArray } from '@ember/array';
import { merge } from '@ember/polyfills';
import { assign } from '@ember/polyfills';

export default Serializer.extend({
serialize(object) {
Expand All @@ -17,7 +17,7 @@ export default Serializer.extend({
'@href': '/features',
'@representation': 'standard'
};
return merge(metadata, object.attrs);
return assign(metadata, object.attrs);
}
}
});
4 changes: 2 additions & 2 deletions mirage/serializers/preference.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Serializer } from 'ember-cli-mirage';
import { isArray } from '@ember/array';
import { merge } from '@ember/polyfills';
import { assign } from '@ember/polyfills';

export default Serializer.extend({
serialize(object) {
Expand All @@ -17,7 +17,7 @@ export default Serializer.extend({
'@href': '/v3/preferences',
'@representation': 'standard'
};
return merge(metadata, object.attrs);
return assign(metadata, object.attrs);
}
}
});