Remove API-fetched deployment variables #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
force-pushed
the
bd-new-deployment-environment-variables
branch
from
744db8f
to
4a4ed08
Compare
Thanks to @BanzaiMan’s travis-ci/travis-scheduler#38 and travis-ci/travis-build#848, these are now present as environment variables rather than needing to be fetched via the GitHub API.
backspace
force-pushed
the
bd-new-deployment-environment-variables
branch
from
4a4ed08
to
05b9a52
Compare
|
I am perhaps more excited about this than it warrants! It’s just a pleasure to not have to consult the GitHub API for these useful pieces of information. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @BanzaiMan’s travis-ci/travis-scheduler#38 and
travis-ci/travis-build#848, these are now present as
environment variables rather than needing to be fetched
via the GitHub API.