Freebsd pkg addon #154
Merged
Freebsd pkg addon #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good for me. @svenfuchs would you mind to double check?
svenfuchs
suggested changes
Mar 3, 2020
| def define | ||
| prefix :packages | ||
|
|
||
| map :packages, to: :seq, alias: :package, summary: 'Package names', eg: 'cmake' |
There was a problem hiding this comment.
i'd suggest using names here pkg already suggests "package", so "package names" would read better than "package package".
also, i'd suggest not adding aliases unless we have to.
There was a problem hiding this comment.
It was suggestion from freebsd community c (like apt)
pkg:
packages:
- cmake
- vim
and alias
pkg:
package: cmake
There was a problem hiding this comment.
On Ubuntu builds we keep aliases as follows:
addons:
apt:
packages:
- so FreeBSD community proposed something consistent. The
aptis replaced withpkgin FreeBSD, which may be not so fortunate, but I'm for keeping it consistent with linux based mechanism - less confusion for users
There was a problem hiding this comment.
and we already made it consistent on macos:
addons:
homebrew:
packages:
so if we introduce something different now, we should allow it for all other OSes - I'd prefer to give less options to the users
* master: do not explode on missing msg args matrix key unsupported by lang does not leave bogus job do not explode on missing msg args check loaded? rather than imports try fixing configs order depth-first fix spec do not explode on non-hash configs match stage on jobs.exclude
michal-at-travisci
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.