Update typhoeus to 1.x #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, master is failing in the same way, even though the tests are generally passing.. I was able to fix the JSON failure with a fix to the Gemfile, but the "NotLoggedIn" is presently beyond my pay grade (and not caused by this checkin) :) |
|
|
|
Okey doke. I'm not up to fixing that at the moment, so I'll pull this back! |
|
@junghans - Do you have any insight as to why Typhoeus v1 breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of Gemfile solving, having typhoeus on an old version restricts the version we can use in our app. Tests still pass.