-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added log streaming support #64
Conversation
Oh my god. <3 Can you look into the 1.8 failures? |
Also, we should integrate that with the |
Oh wow! I completely missed those failures! I'll look into that right away. |
Oh, whoops, I found the problem. I didn't read the |
Ugh, there is a problem with Rubinius. I'm looking into it... |
Hmm, I haven't been able to reproduce the error locally. Do you have any ideas, @rkh? |
@Aaron1011 I don't know. Can you maybe ping someone in #rubinius on freenode about this? Heading out, can also spin up a debug VM later. One thing you can also try is running Rubinius in 1.9 mode (simply edit the .travis.yml). |
I realized that the reason for the failure on Ruby 1.8 with openssl-nonblock was because |
Sorry, pusher-client needs to go to the gemspec, could you open an issue with them about this? |
\o/ |
I'm starting to think that |
It shouldn't be unmaintained, it is looked after by pusher. We can reach out to them? |
According to this, they don't provide "official support" for the Ruby client. But I do agree that we should reach out to them. |
I've contacted Pusher through their support form. Hopefully, they will take a look at my PR soon. |
I've merged this for you now, guys. Sorry about the delay! |
I'll add it to the gemspec. |
@adamyeats is deploying |
This should be deployed now, @Aaron1011. Thanks! |
@rkh: I'm going to squash the commits into one. Everything should be good to merge. |
@stream = Travis::Tools::Stream.new | ||
@stream.on_data data | ||
@stream.on_finished finished | ||
@stream.subscribe(job.id) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This is a really good start, but exposes the fact that we use pusher a bit too much. I think I'll merge it into a branch so I can work on it, too. |
Okay, sounds good! Sorry about the problems. |
No need to apologise. I need to figure out how to get this working with pro. |
I've allowed the api key to be passed as a parameter, but I'm not sure of the best way to have it use the Pro api key. |
The API key is available through the API:
Of course, the Pro API requires more things such as authenticating against the Pusher stream, which I don't really know how works. |
@receive.call(data) | ||
end | ||
|
||
@socket["#{JOB_PREFIX}#{id}"].bind('job:finished') do |data| |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@rkh: Thanks for all of the additional code you added to this! It looks awesome! Sorry about the small amount I ended up contributing. |
Don't worry, your code made me understand how the pusher client works. |
This resolves issue #15