rename "instance booted ago" to "instance boot time" #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorwwwwwwwwwwwwwwwwwwww
requested review from
sarahhodne,
meatballhat,
Lyoness and
emdantrim
Lyoness
approved these changes
Feb 15, 2017
emdantrim
approved these changes
Feb 15, 2017
sarahhodne
reviewed
Feb 16, 2017
janitor.go
Outdated
| @@ -104,7 +104,7 @@ func (j *Janitor) handleVM(ctx context.Context, | |||
|
|
|||
| if bootTime != nil { | |||
| bootedAgo := time.Now().UTC().Sub(*bootTime) | |||
| logger.WithField("booted_ago", bootedAgo).Info("instance booted ago") | |||
| logger.WithField("booted_ago", bootedAgo).Info("instance boot time") | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
updated! |
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 43.77% 43.77%
=======================================
Files 5 5
Lines 265 265
=======================================
Hits 116 116
Misses 138 138
Partials 11 11
Continue to review full report at Codecov.
|
igorwwwwwwwwwwwwwwwwwwww
deleted the
igorwwwwwwwwwwwwwwwwwwww-patch-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.