backend/jupiterbrain: parse SSH key on backend init #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of loading, parsing and decrypting the key on every SSH connect, this does it only once when the worker is first set up. Fixes #206.
|
Tested in staging by running a few jobs in parallel, and I observed no issues. |
|
On second thought, it'd probably be best to port this over to the other providers too. |
|
Will make some more changes to this tomorrow to port the changes over to the other backends too. |
The different backends were doing a lot of common SSH logic that is more or less the same across all packages. This extracts it to a subpackage that they all can use without having to re-do all of the logic. This also brings the recent improvements to the SSH logic in the jupiterbrain backend over to the other backends.
|
Alright, I ported everything over to the other backends by extracting the functionality to an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading, parsing and decrypting the key on every SSH connect, this does it only once when the worker is first set up.
Gonna test this in staging once the build passes and I have a binary to test with.
Fixes #206.