MTR_OPTIONS processed incorrectly

[z-eos]

in rc script, MTR_OPTIONS variable declared this way:
export MTR_OPTIONS='-4 -b -t -o "LSD NBAW V GMX" -z'

in shell, env(1) shows this:
MTR_OPTIONS=-4 -b -t -o "LSD NBAW V GMX" -z

but on attempt to mtr any address we get:
mtr: Unknown field identifier: "

so, it looks like mtr parses the option wrong way

[rewolff]

From the error message it looks as if mtr is seeing one of the double quotes.

You are supposed to pass the string "LSD NBAW V GMX" as a single string to MTR. But your shell would normally cut that string into pieces and pass them as separate arguments to MTR at the spaces. So that is why you put the quotes around.
So mtr should see: argv[4] = "-o";
that is: The argv[4] pointer points to an address with a - sign in it. The next one is a lower case o, and after that there is a 0 terminating the string.
Similarly argv[5] should be: "LSD NBAW V GMX", the pointer pointing directly at the 'L' and the X being followed by the terminating 0.

So specifying the string with spaces in it as an argument requires you to escape them from the shell.

However, when using this in mtr-options, things get a bit tricky: mtr has to do the parsing itself. At the moment it does not do the stuff with the quotes, so it blindly passes the string "LSD as the argument to the -o option.

Either we have to improve the split into separate chunks function ("parse_mtr_options" in the source) to handle the quotes. Or we have to do a workaround: You specify _ in the environment variable and that gets turned into a space in the code.

OK. Implemented the workaround.
Check the latest git. (in 5 minutes).

[z-eos]

confirm
it works

[z-eos]

patch provided by Sergey Poznyakoff (gray at gnu dot org dot ua) is attached

• ui/mtr.c (parse_mtr_options): Correctly parse quoted arguments
  mtr.c.patch.txt