New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref ticket #794 awk overflow #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review awk logic before replacing with cat.
possible fix for original problem would be to change $1 into string. in combine.awk
Add duplicate filtering to stripped.csv processing
@sijskes Simon, I saw your first comment regarding the de-duping, and added pipe with !seen[] before I saw your second comment regarding combine.awk. I've updated the PR with !seen[] approach which works well in in my own post-build processing of the contact data. For your review. |
What you have done, is basically added a cat step. Better fix the combine.awk instead. The '!seen' fix u used suffers from the same problem as combine.awk (same functionality, same logic). The fix is converting the implicit integer into a string. This could be applied to combine.awk. Something like "x"$1 or ""$1 will convert to string. The $^ you have removed, is also a proper Makefile construct. |
…'t important Avoids pointer overflow of free() in awk
refactored brute for file concatenation to avoid 64K overflow in awk when executing combine.awk in stripped.csv target of the DB make.