Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mic bargraph silent #823

Merged
merged 4 commits into from Oct 16, 2017

Conversation

f1rmb
Copy link

@f1rmb f1rmb commented Oct 16, 2017

Hi,
This get rid of one GCC warning, and keep the mic bargraph hidden when app menu is displayed.

Cheers.

Daniel

@travisgoodspeed
Copy link
Owner

I'll be happy to merge this once all tests are passing, but a function prototype seems to be missing.

src/display.c: In function 'draw_micbargraph':
src/display.c:95:5: error: implicit declaration of function 'Menu_IsVisible' [-Werror=implicit-function-declaration]
     if( gui_opmode2 == OPM2_MENU || Menu_IsVisible() ) {
     ^
cc1: all warnings being treated as errors
make[3]: *** [display.o] Error 1

@f1rmb
Copy link
Author

f1rmb commented Oct 16, 2017

Oops, I guessed app menu was always used ;-).
Fix on the go.

Cheers.

@travisgoodspeed travisgoodspeed merged commit a9ebf0f into travisgoodspeed:master Oct 16, 2017
@f1rmb f1rmb deleted the mic_bargraph_silent branch October 17, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants