Updates URL regex to make : and @ optional #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the regex as it currently stands, having a
:and@are required in your shop name. I've never seen a username/password used as part of a shop name so I'm not sure why it would be required here. The examples in the README don't use it and when you try them you just get errors from ActiveResource: fakeweb doesn't capture the request (because the URL doesn't match) and it tries to go out to the internet for real. See issue #7 for the errors I was seeing.By making the : and @ optional, the examples work just fine, but current shop names that happen to contain a username/password will continue to work.