Fix arity of Date.parse and DateTime.parse #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a call to Date.parse or DateTime.parse passed a second or third argument while Timecop was loaded, the patched parse method would not match the arity since it was only expecting a single arg.
|
+1 |
|
👍 |
|
+1 |
travisjeffery
pushed a commit
that referenced
this pull request
Feb 19, 2015
Fix arity of Date.parse and DateTime.parse
|
Awesome! Thanks! |
|
Sweet, thanks for the quick merge/release! |
|
@cgunther thank you for fixing my fix. I forgot to check my implementation against the stdlib. I have learned my lesson. ;) |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
485c4a4 introduced a regression where the method signature of
Date.parseandDateTime.parseno longer matched the stdlib version. Both support 3 arguments, however the patched method only accepted one. This updates them to accept any number of arguments, passing them as is to the original method when the patch doesn't apply (not a weekday), or grabbing just the first argument when the patch does apply.This also included a commit to rename a test file to have the _test suffix so it'd be picked up by the test runner.