Disable Process#clock_gettime mocking by default #426
Conversation
|
@joshuacronemeyer This might be the simplest fix. I was also thinking it could be nice if the Just wanted to get something up quickly for feedback. |
|
@alexcwatt code looks good. I think it's worth a mention in the README. Let me know if you'd like me to write something and add to this PR or if you got it. And thanks for the quick turnaround! @olly and @nerdrew from the next release the process clock freezing will be opt-in. Feel free to weigh in on this. |
|
@joshuacronemeyer I'm happy with that proposal. I don't personally have any need to mock the |
|
Glad it looks good! Feel free to take over the PR to update README. Thank you for flagging this issue; I definitely didn't anticipate it.
…On Fri, Jun 14, 2024, at 12:54 PM, Oliver Legg wrote:
@joshuacronemeyer <https://github.com/joshuacronemeyer> I'm happy with that proposal. I don't personally have any need to mock the `Process` clock, but to me it seems like needing to is a pretty niche use-case and so opting-in is appropriate.
—
Reply to this email directly, view it on GitHub <#426 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYU6KAYFBNBRQ25WGUEXLZHMN5PAVCNFSM6AAAAABJJF3N7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGQZDCNRTGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
ok. i will shepherd this to a release this weekend. thanks all. @alexcwatt i actually wasn't surprised that something like this cropped up, even minor changes tend to bring folks out of the woodwork pretty fast. |
|
closed this in favor of this #427 because I don't know what i'm doing haha. All i could figure out how to do was create my own branch and merge alex's branch into it and then make a PR from that. |
#425