[Bug fix] Timezones travel/freeze losing zone awareness on to_date or Date.today #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisjeffery
pushed a commit
that referenced
this pull request
Mar 8, 2013
[Bug fix] Timezones travel/freeze losing zone awareness on to_date or Date.today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
For edge cases with odd timezones, I noticed a bug where certain (+12hr) zones would create an incorrect
to_dateorDate.today.I've used
Marshall Is.as an example as they are +12 and generally made my tests fail.The bug was caused by TimeStackItem on call of
def datewould not pass the current Time object, which may be Time.zone applicable. Thus onto_datethe tz applicable values are stripped, rather than converted.Best regards,
Tom