-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding custom methods to result #120
Conversation
FYI @travispavek |
Previous version was already returning a empty dict since it was attempting to use the same iterator twice
1 similar comment
Hi @travispavek let me know if you need more details on my changes. Thank you |
@pierreluctg thanks for the pr. I meant to look at it this weekend but some stuff came up. I will look at it tonight or tomorrow. |
Hi @travispavek any update on this PR? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the terrible delay in getting to this.
@travispavek looks like the Python 2.6 tests are failing. Do you want to keep Python 2.6? https://www.python.org/dev/peps/pep-0361/#release-lifespan |
@pierreluctg that's a good point, we can drop support for python 2.6. I will merge this in this weekend and go through the new pypi package management stuff. |
Thank you @travispavek |
No description provided.