Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom methods to result #120

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Conversation

pierreluctg
Copy link
Contributor

No description provided.

@pierreluctg
Copy link
Contributor Author

FYI @travispavek

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage decreased (-0.1%) to 79.791% when pulling 190cbcb on pierreluctg:master into 118b915 on travispavek:master.

Previous version was already returning a empty dict since it was attempting to use the same iterator twice
@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage decreased (-0.1%) to 79.805% when pulling 99a6aab on pierreluctg:master into 118b915 on travispavek:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 79.805% when pulling 99a6aab on pierreluctg:master into 118b915 on travispavek:master.

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage decreased (-0.2%) to 79.753% when pulling f23fc96 on pierreluctg:master into 118b915 on travispavek:master.

@pierreluctg
Copy link
Contributor Author

Hi @travispavek let me know if you need more details on my changes.

Thank you

@travispavek
Copy link
Owner

@pierreluctg thanks for the pr. I meant to look at it this weekend but some stuff came up. I will look at it tonight or tomorrow.

@pierreluctg
Copy link
Contributor Author

Hi @travispavek any update on this PR?

Thank you

Copy link
Owner

@travispavek travispavek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the terrible delay in getting to this.

@pierreluctg
Copy link
Contributor Author

@travispavek looks like the Python 2.6 tests are failing.

Do you want to keep Python 2.6? https://www.python.org/dev/peps/pep-0361/#release-lifespan

@travispavek
Copy link
Owner

@pierreluctg that's a good point, we can drop support for python 2.6. I will merge this in this weekend and go through the new pypi package management stuff.

@pierreluctg
Copy link
Contributor Author

Thank you @travispavek

@travispavek travispavek merged commit 94bce19 into travispavek:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants