fix: #9 use encoding cp1251 to open MCNP files and #8 'is' instead of 'equal' #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files may contains symbols, which are not unicode compatible. By default Python opens files in 'utf-8' encoding and this causes error for files produced from SuperMC for example.
dvp2015
changed the title
|
Currently fails on python2.7. In general, I think it is not correct to hardcode the cp1251 encoding. Maybe as a command line option. Can you provide an example input file that requires the cp1251 encoding, which can be added to travis_tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files may contains symbols, which are not unicode compatible.
By default Python opens files in 'utf-8' encoding and this causes
error for files produced from SuperMC for example.