Added dark theme from ColinDuquesnoy. Also fixed a warning #285
Conversation
|
Awesome ! Thanks ! |
| if (!f.exists()) { | ||
| printf("Unable to set stylesheet, file not found\n"); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Don't you think we should make it a preference ?
As far as I understand this overrides the default theme of the operating system. I suspect that some users have dark theme defined at the Windows/Linux level, and it would be nice if we could avoid to enforce it.
|
Yes it should be optional [Read a configuration option]. Also the background of the tablewidget is not affected by this change, since it gets the color from the app palette. The latest push to my fork "fixes" this. Why that png? It was in the QDarkStyleSheet repo https://github.com/ColinDuquesnoy/QDarkStyleSheet. Why no more work before the pull request? I needed the feature within one day delay so I did a quick-and-dirty fix. Also I thought it could be good to share the change for further development |
|
I like the idea, let's see if I can improve it a bit. Here is what it looks like on my machine:
|
|
You need to improve line 5-9. Also I think the selected background should be slightly darker |
|
Closing in favor of #299 ;) |
A dark theme is preferred in a "Live environment" since you do not want your face look like a ghost. This fix needs to be polished, so the dark theme is optional. But it demonstrates how it can be fixed.