Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make success messages more dynamic and compliant with standard django #220

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Make success messages more dynamic and compliant with standard django #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20150ef
Make success messages more dynamic and compliant with standard django
christianwgd May 2, 2023
c6e547d
Merge branch 'master' into dynamic_success_message
trco Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion bootstrap_modal_forms/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ class FormValidationMixin:
Generic View Mixin which saves object and redirects to success_url if request is not ajax request. Otherwise response 204 No content is returned.
"""

def get_success_message(self):
if hasattr(self, 'success_message'):
return self.success_message

def get_success_url(self):
if self.success_url:
return self.success_url
Expand All @@ -93,7 +97,7 @@ def form_valid(self, form):
return HttpResponse(status=204)

form.save()
messages.success(self.request, self.success_message)
messages.success(self.request, self.get_success_message())
return HttpResponseRedirect(self.get_success_url())


Expand Down