Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallaby timeouts... All promise returning calls require catch(done) #15

Closed
jsobell opened this issue Jul 22, 2016 · 1 comment
Closed
Labels

Comments

@jsobell
Copy link
Contributor

jsobell commented Jul 22, 2016

The reason errors in Wallaby fail with 2000ms timeouts is because there are no catches on the promises in the tests.
Add .catch(done) to the end of each then() in the tests causes any error to correctly logged.
e.g.

        validationGroup.isValid()
            .then(function(isValid){
                expect(isValid).to.be.true;
                validationGroup.release();
                done();
            }).catch(done);
@grofit
Copy link
Member

grofit commented Jul 22, 2016

I believe this is all fixed with the latest PR so will flag it as complete feel free to re-open.

@grofit grofit closed this as completed Jul 22, 2016
@grofit grofit added the bug label Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants