Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dplyr 1.0.0 #16

Merged
merged 2 commits into from Jun 1, 2020
Merged

Support dplyr 1.0.0 #16

merged 2 commits into from Jun 1, 2020

Conversation

chezou
Copy link
Member

@chezou chezou commented Mar 23, 2020

RTD has an issue with dplyr 1.0.0 which is coming major version soon. After releasing the 1.0.0, we should ensure tibble data frames as a table and database list.

== CHECK RESULTS ========================================

*   checking tests ...
    ```
     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      >
      > test_check("RTD")
      ── 1. Error: list_tables works with mock (@test-table.R#18)
───────────────────
      `new` must be a tibble
      Backtrace:
       1. testthat::expect_equal(dplyr::count(tables)$n, 2)
       4. dplyr::count(tables)
       5. dplyr::dplyr_reconstruct(out, x)

      ══ testthat results
═══════════════════════════════════════════════════════════
      [ OK: 26 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
      1. Error: list_tables works with mock (@test-table.R#18)

      Error: testthat unit tests failed
      Execution halted
    ```

@chezou
Copy link
Member Author

chezou commented Jun 1, 2020

dplyr 1.0.0 has been released. Now is the time to apply this patch.
https://github.com/tidyverse/dplyr/releases/tag/v1.0.0

@chezou chezou changed the title [WIP] Support dplyr 1.0.0 Support dplyr 1.0.0 Jun 1, 2020
@chezou
Copy link
Member Author

chezou commented Jun 1, 2020

Not sure why, but Travis CI badge hasn't been updated, but CI passed. Will merge.

@chezou chezou merged commit b1e279b into master Jun 1, 2020
@chezou chezou deleted the dplyr-100 branch June 1, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant