Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting number of active workflow attempts per site #293

Closed
frsyuki opened this issue Sep 19, 2016 · 1 comment
Closed

Limiting number of active workflow attempts per site #293

frsyuki opened this issue Sep 19, 2016 · 1 comment

Comments

@frsyuki
Copy link
Member

frsyuki commented Sep 19, 2016

There're schedules and REST API (PUT /api/attempts) that issue new attempts. require> also issues a new attempt but it should be implemented as an alias of REST API.

@frsyuki
Copy link
Member Author

frsyuki commented Sep 19, 2016

Implementation ideas:

Schedule: if number of active attempts reached hard limit, starting a new schedule delays for several minutes (1 minute first, 10 minutes maximum, using exponential back-off is ideal). After the wait, scheduler tries to issue attempts again. I think this is good because users have chance to fix the schedule when scheduling is blocked.

REST API: if number of active attempts reached hard limit, sever returns 429 Too Many Requests or 400 Bad Request.

Soft limit: if number of active attempts reached soft limit, scheduler and REST API put a new attempt to a queue and don't put tasks. Workflow executor puts tasks of the attempts later. Soft limit could be used also for multi-tenant scheduling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant