Introduce EcsCommandExecutor #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyama
reviewed
Jun 3, 2019
digdag-standards/src/main/java/io/digdag/standards/command/EcsCommandExecutor.java
Show resolved
Hide resolved
yoyama
reviewed
Jun 3, 2019
digdag-standards/src/main/java/io/digdag/standards/command/CommandExecutorModule.java
Show resolved
Hide resolved
|
@yoyama thank you for reviewing.
Thanks, got it. I will take care of that. and documentation as well. |
muga
force-pushed
the
introduce_ecs_command_executor
branch
2 times, most recently
from
daefaf1
to
61302a8
Compare
muga
force-pushed
the
introduce_ecs_command_executor
branch
from
61302a8
to
c8e3b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces EcsCommandExecutor, which enables submitting scripting operators, e.g. "py>", "rb>" and "sh>", and running the script on ECS cluster as ECS tasks. The functionality is based on command executor SPI v2. It will be released in v0.10.