Add wait operator by porting https://github.com/yoyama/digdag-wait-op
#1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
changed the title
komamitsu
changed the title
|
Let me add |
to `wait` operator
komamitsu
changed the title
wait operator by porting https://github.com/yoyama/digdag-wait-op
yoyama
reviewed
Jan 21, 2021
| if (!pollIntervalStr.isPresent()) { | ||
| return Optional.absent(); | ||
| } | ||
| pollInterval = Durations.parseDuration(pollIntervalStr.get()); |
There was a problem hiding this comment.
I guess we may make the codes simple by using Optional.transform().
But not strong opinion.
try {
Optional<Duration> pollInterval = config
.getOptional("poll_interval", String.class)
.transform(Durations::parseDuration);
if (pollInterval.isPresent()) {
logger.debug("wait poll_interval: {}", pollInterval.get());
}
return pollInterval;
}
catch (RuntimeException re) {
throw new ConfigException("Invalid configuration", re);
}
yoyama
reviewed
Jan 21, 2021
| assertThat(result.duration, greaterThan(baselineDuration)); | ||
| assertThat(result.duration, lessThan( | ||
| // Actual wait duration can be longer than the specified 10 seconds for some reason | ||
| baselineDuration.plusSeconds((long) (expectedDuration * 1.5)))); |
There was a problem hiding this comment.
I have a bit concern in this condition.
When CI performance is degraded, it may fail unexpectedly.
There was a problem hiding this comment.
Agreed. Just tweaked the value since I don't think there is an easy robust way to handle the concern.
yoyama
approved these changes
Jan 21, 2021
|
Thanks! |
yoyama
pushed a commit
to yoyama/digdag
that referenced
this pull request
Dec 27, 2021
Add `wait` operator by porting https://github.com/yoyama/digdag-wait-op
szyn
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Add 'wait' operator * Add test for `wait` operator * Add description about `wait` operator * Refactoring * Add `blocking` and `poll_interval` options to `wait` operator * Small refactoring * Replace nullable value with Optional * Make the key name clearer * Fix typo * Add missing test case * Refactoring * Use a safer expected value * Merge pull request #1520 from treasure-data/wait-oprator Add `wait` operator by porting https://github.com/yoyama/digdag-wait-op Co-authored-by: Mitsunori Komatsu <komamitsu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The developers and users of Digdag often want to stop a workflow for a specific duration to emulate a long running task.
sh>: sleep 5may be a workaround, but it's a blocking operator and doesn't fit when we want to emulate long running non-blocking operator task.This pull request ports https://github.com/yoyama/digdag-wait-op with some minor changes to address the above pain point.