Fix td operators tests by using HTTPS
#1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
changed the title
td operators tests by using HTTPS
yoyama
approved these changes
Apr 9, 2021
serihiro
approved these changes
Apr 9, 2021
szyn
approved these changes
Apr 9, 2021
yoyama
pushed a commit
to yoyama/digdag
that referenced
this pull request
May 21, 2021
* Fix a faling test * For investigation * Revert * Fix * Use HTTPS for td operators tests * Stop using HTTP proxy * Stop relaying on littleshot req interruptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treasure Data's API endpoint doesn't accept HTTP requests now. In this PR, we make all accesses to TD via HTTPS in the test code.
But we need to tentatively skip some test verifications (e.g.
acceptance.td.TdIT#testRetries()) in addition.In this kind of tests,
tdoperator accesses to td-api through a HTTP proxy serverorg.littleshot.proxycreated in the test code for these purposes:But Treasure Data API doesn’t accept any HTTP request now. So I’ve tried using HTTPS requests. But the verification of request call count in the test code failed.
That’s because
littleshotproxy ’s request interruption doesn’t work for HTTPS request. It creates a SSL tunnel after handling CONNECT method and doesn’t touch following request calls. With currentlittleshotproxy, we can’t achieve the original verification in the test code, so I’ll comment out them since current situation blocks our development. But we need to take care of it soon because it’s kinda lack of testing.