Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport enhancements on /api/workflows #1720

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Conversation

yoyama
Copy link
Contributor

@yoyama yoyama commented Mar 8, 2022

Back port from Treasure Workflows.
Enhance GET /api/workflows as follows.

  • Add a parameter order to change sort order ascending/descending. asc or desc. Default is asc
  • Add a parameter search_project_name to include project name in search by name_pattern parameter. true or false. Default is false

These parameters are optional and default behavior will not break compatibility.

yoyama and others added 3 commits March 8, 2022 11:33
* Implement in ProjectStore.
* Implement parameters to `GET /api/workflows`
* Add test cases.
* Add an integration test for 'GET /api/workflows'.
* Fix last_id with desc.

Co-authored-by: rune-chan <renee.chang@treasure-data.com>
@yoyama yoyama marked this pull request as ready for review March 8, 2022 03:12
@yoyama yoyama requested a review from szyn March 8, 2022 03:12
@yoyama yoyama merged commit 9687645 into master Apr 15, 2022
@yoyama yoyama added this to the v0.10.5 milestone Apr 18, 2022
@szyn szyn deleted the backport-api-workflows branch April 22, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants