Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CircleCI failures and IT failures #1782

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Fix CircleCI failures and IT failures #1782

merged 2 commits into from
Jan 11, 2023

Conversation

yoyama
Copy link
Contributor

@yoyama yoyama commented Jan 11, 2023

This PR contains multiple fix

  • Fix CircleCI failure due to change of credential handling
  • Fix IT failures which are caused by Add CLI options #1778

@yoyama yoyama requested review from szyn and rune-chan January 11, 2023 05:13
rune-chan
rune-chan approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@rune-chan rune-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoyama yoyama merged commit 8e1b24f into master Jan 11, 2023
@yoyama yoyama deleted the fix-circleci-emr-td branch January 11, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rune-chan rune-chan rune-chan approved these changes

@szyn szyn Awaiting requested review from szyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoyama @rune-chan