Add a logic to check credentials before searching issues #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thangnc
changed the title
thangnc
changed the title
uu59
reviewed
Sep 21, 2017
lib/embulk/input/jira.rb
Outdated
| @@ -62,6 +62,9 @@ def self.guess(config) | |||
| retry_initial_wait_sec = config.param(:retry_initial_wait_sec, :integer, default: 1) | |||
| retryer = retryer(retry_limit, retry_initial_wait_sec) | |||
|
|
|||
| # Get credential before going to search issue | |||
| jira.get_user_credential(username) | |||
There was a problem hiding this comment.
Method name is get_xxx but we don't use that result.
That method does check/validate/authenticate/etc actually, so renaming it would be better.
There was a problem hiding this comment.
Thank @uu59. Will update now
|
@uu59 PTAL |
uu59
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES
timeout_and_retrywill fall in loop. This PR will fix it by adding a logic to check credentials and throw the EmbulkConfig before searching issues