Fix hang when validate task #56

minidragon88 · 2019-04-04T05:37:51Z

Problem:

When validate the task in jira, we try to ping the host. However, because of missing setConnectTimeout property for the HttpURLConnection then when request timeout, the plugin will hang forever.

Solution:

Using apache http client with proper timeout - connection timeout and socket time out to ping the host

…uration

huylenq

I left some comments. Besides, I think you mean missing setSocketTimeout, not setConnectTimeout, right?

src/main/java/org/embulk/input/jira/client/JiraClient.java

src/main/java/org/embulk/input/jira/util/JiraUtil.java

huylenq

LGTM

minidragon88 added 7 commits April 4, 2019 12:24

Move timeout to constant

9ede99e

Using closable client and request for safe, add socket timeout config…

29d52ce

…uration

Using http client to check host exist or not

ce4dcbb

Update test code

7ecef99

Inline request config

9cbf1ca

Update version and remove unused configuration

0ec723e

Update change log

cc40329

minidragon88 requested a review from huylenq April 4, 2019 05:51

huylenq reviewed Apr 6, 2019

View reviewed changes

src/main/java/org/embulk/input/jira/util/JiraUtil.java Show resolved Hide resolved

Using declared variable instead of re-getting from task

f4602e9

huylenq approved these changes Apr 8, 2019

View reviewed changes

minidragon88 merged commit c3ed36f into master Apr 8, 2019

minidragon88 deleted the fix_hang_when_validate_task branch April 8, 2019 07:28

Provide feedback