Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConfigSource#getObjectNode #57

Merged
merged 6 commits into from
Nov 13, 2019
Merged

Remove ConfigSource#getObjectNode #57

merged 6 commits into from
Nov 13, 2019

Conversation

minidragon88
Copy link
Contributor

Since Embulk will deprecate ConfigSource#getObjectNode so this PR will remove these usage out of embulk-input-jira plugin

trung-huynh
trung-huynh reviewed Nov 12, 2019
View reviewed changes
Copy link

@trung-huynh trung-huynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 2 comments for further discussions.

src/main/java/org/embulk/input/jira/util/JiraUtil.java Outdated Show resolved Hide resolved
src/main/java/org/embulk/input/jira/util/JiraUtil.java Outdated Show resolved Hide resolved
trung-huynh
trung-huynh approved these changes Nov 13, 2019
View reviewed changes
Copy link

@trung-huynh trung-huynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minidragon88 minidragon88 merged commit d69abbe into master Nov 13, 2019
@minidragon88 minidragon88 deleted the remove_getObjectNode branch November 13, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung-huynh trung-huynh trung-huynh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minidragon88 @trung-huynh