Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown in case no records for dynamic schema #70

Merged
merged 2 commits into from Oct 4, 2021
Merged

Graceful shutdown in case no records for dynamic schema #70

merged 2 commits into from Oct 4, 2021

Conversation

minidragon88
Copy link
Contributor

Current when no data in dynamic schema runs, plugin will throw ConfigException.
This PR is aimed to resolve this problem by exit the jobs at successfully.

@minidragon88 minidragon88 requested a review from a team as a code owner October 4, 2021 03:22
kietdo360
kietdo360 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@kietdo360 kietdo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minidragon88 minidragon88 requested review from kietdo360 and a team October 4, 2021 03:30
flexgrip
flexgrip approved these changes Oct 4, 2021
View reviewed changes
Copy link

@flexgrip flexgrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations.

@flexgrip
Copy link

flexgrip commented Oct 4, 2021

… and approved 👍

@minidragon88 minidragon88 merged commit 5ec0ccc into master Oct 4, 2021
@minidragon88 minidragon88 deleted the dynamic_schema_graceful_exit branch October 4, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexgrip flexgrip flexgrip approved these changes

@kietdo360 kietdo360 Awaiting requested review from kietdo360

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minidragon88 @flexgrip @kietdo360