add grouping column setting #3
Merged
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://kb.mailchimp.com/segments/add-groups-to-a-list supoort subscribe group. `grouping_columns` specifies group details in the array. If, row has column name include `grouping_columns`, column value used group names. The value of the column is more that can be specified in a comma-separated
| @@ -21,6 +21,7 @@ add e-mail to List in MailChimp. | |||
| - **email_column**: column name for email (string, default: 'email') | |||
| - **fname_column**: column name for first name (string, default: 'fname') | |||
| - **lname_column**: column name for last name(string, default: 'lname') | |||
| - **grouping_columns**: column names array for group name | |||
There was a problem hiding this comment.
(array, default: nil) is more kindly describe :)
|
Some validations to detect misconfigured Update: |
| @@ -21,6 +21,7 @@ add e-mail to List in MailChimp. | |||
| - **email_column**: column name for email (string, default: 'email') | |||
| - **fname_column**: column name for first name (string, default: 'fname') | |||
| - **lname_column**: column name for last name(string, default: 'lname') | |||
| - **grouping_columns**: column names array for group name(array, debfault: nil) | |||
|
I commented some points, otherwise LGTM. |
takkanm
force-pushed
the
add_grouping_setting
branch
from
b6c92b0
to
c8c3229
Compare
|
Thank you for review. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://kb.mailchimp.com/segments/add-groups-to-a-list
supoort subscribe group.
grouping_columnsspecifies group details in the array.If, row has column name include
grouping_columns,column value used group names.
The value of the column is more that can be specified in a
comma-separated