Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debounce upload events #62

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Debounce upload events #62

merged 2 commits into from
Apr 22, 2021

Conversation

tung-vu-td
Copy link
Collaborator

Reason:

  • There are some lost events If events are continuously uploaded.

@tung-vu-td tung-vu-td requested a review from a team as a code owner March 24, 2021 11:01
kietdo360
kietdo360 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@kietdo360 kietdo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tung-vu-td tung-vu-td requested a review from a team April 19, 2021 04:13
flexgrip
flexgrip approved these changes Apr 19, 2021
View reviewed changes
Copy link

@flexgrip flexgrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations.

@tung-vu-td tung-vu-td merged commit c80a5cb into master Apr 22, 2021
@tung-vu-td tung-vu-td deleted the debounce-upload branch April 22, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexgrip flexgrip flexgrip approved these changes

@kietdo360 kietdo360 kietdo360 approved these changes

@huylenq huylenq Awaiting requested review from huylenq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tung-vu-td @flexgrip @kietdo360