Setup circleci #128
Merged
Setup circleci #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kietdo360
approved these changes
Feb 8, 2021
nmpennypacker
approved these changes
Feb 8, 2021
|
How about removing Travis and AppVeyor configs? Both seem not working anyway, and you could test Windows in CircleCI as needed too. |
k0kubun
reviewed
Feb 10, 2021
td-client.gemspec
Outdated
| @@ -26,6 +26,9 @@ Gem::Specification.new do |gem| | |||
| gem.add_development_dependency 'simplecov', '>= 0.5.4' | |||
| gem.add_development_dependency 'rake' | |||
| gem.add_development_dependency 'yard' | |||
| if RUBY_VERSION >= '3.0' | |||
There was a problem hiding this comment.
This file is interpreted by a particular Ruby version on gem push, which means the dependency definition will be changed what Ruby version you'll use for gem push.
You should simply declare the dependency regardless of the Ruby version if you really want to make sure it's specified as a development dependency when you use the gem from Ruby 3.0. Development dependencies of released packages probably don't really matter though.
There was a problem hiding this comment.
Ah I see. I have wrong understanding of RUBY_VERSION in gemspec. Thanks for catching it!
k0kubun
approved these changes
Feb 18, 2021
ybiquitous
added a commit
that referenced
this pull request
Aug 30, 2023
Travis CI and AppVeyor were removed with PR #128. Note that the current CI (Circle CI) page is not public, so we cannot add its badge.
ybiquitous
added a commit
that referenced
this pull request
Aug 30, 2023
Travis CI and AppVeyor were removed with PR #128. Note that the current CI (Circle CI) page is not public, so we cannot add its badge.
ybiquitous
added a commit
that referenced
this pull request
Sep 27, 2023
Travis CI and AppVeyor were removed with PR #128. Note that the current CI (Circle CI) page is not public, so we cannot add its badge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to setup Circle CI: