retriable if content length missmatched #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Good catch! |
It occures by combination OpenSSL raise EOFError and use MessagePack::Unpacker. Therefore, if the size of the body is less than the content length, raise retryable error.
takkanm
force-pushed
the
retriable_msgpack_close_by_openssl_eoferror
branch
from
47920e3
to
56cca61
Compare
|
It was supported to call of Net::Http# request() with block. In addition, it was made so as to rescue the IncompleteError, but It seems to not be retried when call with block. |
|
LGTM! |
takkanm
added a commit
that referenced
this pull request
Jul 29, 2015
…openssl_eoferror retriable if content length missmatched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occures by combination OpenSSL raise EOFError and use
MessagePack::Unpacker.
Therefore, if the size of the body is less than the content length,
raise retryable error.