Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stick footer to the bottom of the page, not the screen #80

Closed
bglamadrid opened this issue Sep 23, 2021 · 4 comments · Fixed by #95
Closed

Stick footer to the bottom of the page, not the screen #80

bglamadrid opened this issue Sep 23, 2021 · 4 comments · Fixed by #95
Assignees
@tcvan0707
Labels
bug hacktoberfest Are you ready?

Comments

@bglamadrid
Copy link
Collaborator

bglamadrid commented Sep 23, 2021 •
edited

I didn't test this correctly before, but I realized the footer takes up too much space, being stuck to the bottom of the screen instead of the bottom of the page.

I believe it should be fixable by changing the template of the StoreComponent. It uses flexbox layout btw.
@bglamadrid bglamadrid added the bug label Sep 23, 2021
@bglamadrid bglamadrid self-assigned this Sep 28, 2021
@bglamadrid bglamadrid added the hacktoberfest Are you ready? label Oct 21, 2021
@bglamadrid bglamadrid removed their assignment Oct 21, 2021
@tcvan0707
Copy link

Hello, can i work on this issue? I want to give it a try.

@bglamadrid
Copy link
Collaborator Author

Hello, can i work on this issue? I want to give it a try.

Sure thing! I'm assigning it to you. Don't hesitate to ask if you have any questions.

tcvan0707 pushed a commit to tcvan0707/ngx-trebol-frontend that referenced this issue Oct 30, 2021
Fixed trebol-ecommerce#80: Stick Footer to the Bottom of the Page
6cbb536
@tcvan0707 tcvan0707 mentioned this issue Oct 30, 2021
Merged
@tcvan0707
Copy link

Please take a look at my pull request and approve it if it is possible. Thank you.

@tcvan0707
Copy link

Hello, can i work on this issue? I want to give it a try.

Sure thing! I'm assigning it to you. Don't hesitate to ask if you have any questions.

Could you please review my PR as soon as possible?

bglamadrid added a commit that referenced this issue Oct 31, 2021
@bglamadrid
Merge pull request #95 from tcvan0707/issue-80
9781509 
Fixed #80: Stick Footer to the Bottom of the Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcvan0707 tcvan0707

Labels
bug hacktoberfest Are you ready?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #80: Stick Footer to the Bottom of the Page tcvan0707/ngx-trebol-frontend
2 participants
@bglamadrid @tcvan0707