Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for v0.2.1 #251

Merged
merged 15 commits into from
Jun 7, 2023
Merged

Cleanup for v0.2.1 #251

merged 15 commits into from
Jun 7, 2023

Conversation

bglamadrid
Copy link
Collaborator

@bglamadrid bglamadrid commented Jun 7, 2023 •
edited

PR Checklist

  • Read the contribution guidelines
  • Added a brief description of these changes to the top of the changelog
  • Changes in code meet test criteria (running mvn test returns exit code 0, without errors)

PR Type

  • Code style (code formatting, local variable naming)

Summary

Housekeeping for the next patch, v0.2.1, introduced and yet unmerged by #250

@bglamadrid
fix: billing address is not always required for checkout
d9dc5f4
@bglamadrid
fix: billing address is only required for enterprise checkout
845272a
@bglamadrid
fix: inclusion of required payment type data
185a7a6
@bglamadrid
fix: inclusion of required sell status data
9ae22af
@bglamadrid
fix: inclusion of required description of sell detail
884787f
@bglamadrid
fix(test): remove cases that no longer apply
ddaf301
@bglamadrid
fix: raise an exception when no payment type is specified
c0695d4
@bglamadrid
fix(test): SalesConverterServiceImpl
afa95b1 
add required service mocks, data & stubbings
@bglamadrid
docs: describe recent changes
5815761
@bglamadrid
build(pom): increment patch version [skip ci]
03c7f51
@bglamadrid
style(editorconfig): update indentation rules
ba927e4
@bglamadrid
style: reformat code with new indentation rules
a370951 
automatic reformat by intellij
style rules set to default except for
- hard wrap at 180 lines
- never wrap field annotations unless line is too long
@bglamadrid
chore: remove public modifier from JUnit 5 test classes
03349af
@bglamadrid
style: optimize imports
5a67d2c
@bglamadrid
docs: describe latest changes
f56f1f6
@bglamadrid bglamadrid merged commit d57bf79 into main Jun 7, 2023
1 check failed
@bglamadrid bglamadrid mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bglamadrid