add redis socket_connect_timeout option #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow for fail-fast on e.g. unreachable or slow redis servers. Case in point unreachable/unbound ipv6 redis as per https://phabricator.wikimedia.org/T118380
|
Looks good. Thanks for the PR! |
ryan-lane
added a commit
that referenced
this pull request
Nov 18, 2015
add redis socket_connect_timeout option
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Nov 24, 2015
"backport" patch from trebuchet-deploy/trebuchet#17 into our fork of trebuchet Bug: T118380 Change-Id: I34d3715eb347ecc9d878d4dcd4306d79bad42f42
|
thanks! I'd add that this depends on pyredis >= 2.10 introduced in redis/redis-py@465e74dce8 though I'm not sure where to add it explicitly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow for fail-fast on e.g. unreachable or slow redis servers. Case in point
unreachable/unbound ipv6 redis as per https://phabricator.wikimedia.org/T118380