-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rules folders into single file where appropriate to simplify down file management #122
Labels
refactor
Refactor functionality without breaking anything
Milestone
Comments
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
tredfern
added a commit
that referenced
this issue
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's been interesting and nice having lots of small files, but in the end it's probably more work than
it's worth. Also, I don't know that it's helping with readability because it results in many more requires
to get the appropriate modules talking within itself.
Switch the folders to a single file, except for those cases where additional segmentation makes sense.
For example, Items might stay as a folder to allow it to contain more file for each item type, but player
could just simplify to a single file to hold all the necessary operations.
I will almost certainly redo this refactor in the other direction in a couple of months. But I will know more
by then.
The text was updated successfully, but these errors were encountered: