Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complete the queries #4

Merged
merged 7 commits into from Mar 19, 2023
Merged

feat: complete the queries #4

merged 7 commits into from Mar 19, 2023

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Mar 17, 2023

No description provided.

@amaanq amaanq marked this pull request as draft March 17, 2023 17:51
@amaanq amaanq force-pushed the queries branch 7 times, most recently from 7fc4925 to cc49237 Compare March 17, 2023 18:52
Copy link
Collaborator

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, as I would move some stuff to different categories.

grammar.js Show resolved Hide resolved
grammar.js Outdated Show resolved Hide resolved
queries/highlights.scm Outdated Show resolved Hide resolved
queries/highlights.scm Outdated Show resolved Hide resolved
queries/highlights.scm Show resolved Hide resolved
queries/highlights.scm Outdated Show resolved Hide resolved
queries/highlights.scm Show resolved Hide resolved
queries/highlights.scm Show resolved Hide resolved
queries/highlights.scm Show resolved Hide resolved
queries/highlights.scm Show resolved Hide resolved
@amaanq amaanq force-pushed the queries branch 5 times, most recently from 091501d to d6ff36c Compare March 18, 2023 12:20
@mfelsche
Copy link
Collaborator

The scanner.c file needs to be added to the binding.gyp for the windows tests to work correctly.

@amaanq amaanq force-pushed the queries branch 4 times, most recently from 23b5c6f to fd66bf3 Compare March 18, 2023 22:31
@amaanq amaanq marked this pull request as ready for review March 18, 2023 22:32
- resolve ambiguity with expressions and call expressions
- properly parse nested comments
@amaanq amaanq force-pushed the queries branch 2 times, most recently from 6505bdc to 43728fc Compare March 19, 2023 04:32
Copy link
Collaborator

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaanq amaanq merged commit 0d4a495 into master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants