Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufferSize and includedRanges options to parse function in TS def #63

Merged

Conversation

thibaultdalban
Copy link
Contributor

@thibaultdalban thibaultdalban commented May 20, 2020

The function signature of Parser.prototype.parse defined in index.js

Parser.prototype.parse = function(input, oldTree, {bufferSize, includedRanges}={})

accepts a third optional parameter.
This commit reflects the signature in TypeScript definition.

depends on #64

A Range contains:
- startIndex
- endIndex
- startPosition
- endPosition
The function signature of `Parser.prototype.parse` defined in index.js
`Parser.prototype.parse = function(input, oldTree, {bufferSize,
includedRanges}={})` accepts a third optional parameter.
This commit reflects the signature in TypeScript definition.
@thibaultdalban thibaultdalban force-pushed the add-included-ranges-option-to-parser branch from 41e0ea6 to fc8d591 Compare May 20, 2020 12:57
@thibaultdalban thibaultdalban changed the title Add included ranges option to parser Add bufferSize and includedRanges options to parser function in TS def May 20, 2020
@thibaultdalban thibaultdalban changed the title Add bufferSize and includedRanges options to parser function in TS def Add bufferSize and includedRanges options to parse function in TS def May 20, 2020
@maxbrunsfeld maxbrunsfeld merged commit c40d598 into tree-sitter:master May 20, 2020
@maxbrunsfeld
Copy link
Contributor

Thanks!

@thibaultdalban thibaultdalban deleted the add-included-ranges-option-to-parser branch May 20, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants