Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++14 to allow building for Electron 11 on MacOS #83

Closed
wants to merge 1 commit into from

Conversation

sergei-dyshel
Copy link

Fixes #82.

@Symbolk
Copy link

Symbolk commented May 30, 2021

@maxbrunsfeld Could this be merged and released? A timely change for me.

@jinu-jang
Copy link

This is just necessary for recent electron versions (v11, v12)
@sergei-dyshel thanks for the fix. This at least got me unblocked for now

@Symbolk
Copy link

Symbolk commented Jun 2, 2021

Right, for those who use electron v11+, here is the manual instruction to rebuild this module:

https://github.com/Symbolk/somanyconflicts#known-issues

@DeeDeeG
Copy link

DeeDeeG commented Jul 4, 2021

👍, and I think not merging this might slow progress on using Electron 11 in the Atom text editor. Might have to fork this package for Atom just to get it building in Electron 11.

@DeeDeeG DeeDeeG mentioned this pull request Jul 4, 2021
64 tasks
@sadick254
Copy link

@maxbrunsfeld What could be holding back this PR from getting merged? As @DeeDeeG has stated this currently blocks Atom from upgrading to electron version 11.4.7.

sadick254 added a commit to atom/atom that referenced this pull request Jul 8, 2021
Copy link

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not c++17?

@@ -31,7 +31,7 @@
"-std=c++0x",
],
'xcode_settings': {
'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14',
'CLANG_CXX_LANGUAGE_STANDARD': 'c++17',

@@ -31,7 +31,7 @@
"-std=c++0x",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"-std=c++0x",
"-std=c++17",

@Symbolk
Copy link

Symbolk commented Sep 2, 2021

After being torture by native module (node-gyp and electron-rebuild) for months, I finally switched to wasm of treesitter, and it seems working fine: https://github.com/Symbolk/somanyconflicts

Maybe this solution helps some of you.

@verhovsky
Copy link
Collaborator

This PR can be closed because #92 (merged) did the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for Electron 11 on MacOS fails
7 participants