Support c++03 #58
Merged
Support c++03 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@414owen It still needs |
wenkokke
added a commit
to wenkokke/fork4pr-tree-sitter-haskell
that referenced
this pull request
Jan 2, 2022
Merged
I have a branch that will definitely remove that: https://github.com/414owen/tree-sitter-haskell/tree/pure-c but it has a kind of infinite-loop type bug at the moment :) |
wenkokke
added a commit
to wenkokke/fork4pr-tree-sitter-haskell
that referenced
this pull request
Jan 2, 2022
tek
pushed a commit
that referenced
this pull request
Jan 3, 2022
wenkokke
added a commit
to wenkokke/fork4pr-tree-sitter-haskell
that referenced
this pull request
Jan 3, 2022
* tree-sitter-master: Removed wasm test to get working ci Make node stricter Remove cache instructions for node Fix wasm tests locally Made parse-examples quieter Build web-tree-sitter with --debug Don't run wasm tests via npm Ensure web-tree-sitter is patched, set CC, name tasks Install emscripten on macOS Add emscripten install Added WASM tests Minor name change Fix test name Fix CI Fix bug in branch selection Add macOS in CI, remove old info from README Convert scanner to C for great good (~˘▾˘)~ (tree-sitter#62) Update patch after tree-sitter#58 (tree-sitter#60)
tek
pushed a commit
that referenced
this pull request
Jan 3, 2022
* Add macOS in CI, remove old info from README * Fix bug in branch selection * Fix CI * Fix test name * Minor name change * Added WASM tests * Add emscripten install * Install emscripten on macOS * Ensure web-tree-sitter is patched, set CC, name tasks * Don't run wasm tests via npm * Build web-tree-sitter with --debug * Update patch after #58 * Convert scanner to C for great good (~˘▾˘)~ (#62) * Made parse-examples quieter * Fix wasm tests locally * Remove cache instructions for node * Make node stricter * Removed wasm test to get working ci * Add macOS in CI, remove old info from README * Fix bug in branch selection * Fix CI * Fix test name * Minor name change * Added WASM tests * Add emscripten install * Install emscripten on macOS * Ensure web-tree-sitter is patched, set CC, name tasks * Don't run wasm tests via npm * Build web-tree-sitter with --debug * Made parse-examples quieter * Fix wasm tests locally * Remove cache instructions for node * Make node stricter * Removed wasm test to get working ci * Removed additional documentation regarding NVIM builds; fixed build badge in README Co-authored-by: Owen Shepherd <owen@owen.cafe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases portability. See #34 (comment).
@tek this should be ready to merge.
This compiles with no output with
g++ -Wall -std=c++03 -c -o out.o src/scanner.cc.I've tested the changes with tree-sitter (my compiler uses c++14 by default), but not with an older compiler.
@wenkokke this should remove the need for most of the
web-tree-sitterpatch, can you give us an update on that?(Sorry, I would compile web-tree-sitter et al. myself, but unless there's a nix derivation, doing so is difficult on my machine)