Multiple Definitions of "scan", "deserialize", and "serialize" when linked with tree-sitter-php

[esheri3]

I am working on a project that links multiple tree-sitter grammar libraries together (ex: tree-sitter-go, tree-sitter-json, ...). Recently, I received "multiple definitions of" errors for "scan", "deserialize", and "serialize" between tree-sitter-html and tree-sitter-php.

Ex:

tree-sitter-php/src/scanner.c:438: multiple definition of `scan'
tree-sitter-html/src/scanner.c:370: first defined here

Are you open to renaming your symbols to have a namespace-like prefix, perhaps something like "tree_sitter_html_scan"? I don't think there's anything I can do on my end short of forking and patching the tree-sitter-html codebase.

Thanks in advance for the consideration!

[esheri3]

@amaanq I believe the issue was introduced here when migrating from C++ to C: 3af1bfd

[amaanq]

Yeah I PRed fixes to bash and php, I'll add one for this

[esheri3]

Awesome! Thanks for such a quick response!Sent from my iPhoneOn Jul 8, 2023, at 9:03 PM, Amaan Qureshi ***@***.***> wrote: Yeah I PRed fixes to bash and php, I'll add one for this —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[esheri3]

Awesome, thanks for the update!

…

On Mon, Jul 10, 2023 at 2:25 PM Amaan Qureshi ***@***.***> wrote: Closed #63 <#63> as completed via #64 <#64>. — Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRF6J7KKKI7NDTC5LZNRLXPRCJDANCNFSM6AAAAAA2DFAEMA> . You are receiving this because you authored the thread.Message ID: ***@***.***>