Add type grammar #89
Merged
Add type grammar #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryx
approved these changes
Mar 23, 2024
| } | ||
| }) | ||
|
|
||
| // Make 'type' the first rule |
There was a problem hiding this comment.
Why do we need this extra magic?
There was a problem hiding this comment.
Without this, we'd have to reuse the compilation_unit entrypoint of the ocaml grammar, so 'a would be parsed as
(compilation_unit (type_variable))instead of
(type (type_variable))The tree-sitter extension mechanism is not really made for changing the entrypoint of a grammar, but for overriding some rules to create a variation of the same grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84.