-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix conditional type parsing association #253
Conversation
Not sure what you mean by update snapshot, if you mean the changes from |
@amaanq this is because no new change is updated. Try adding a new test case and rerunning I reused the term |
Oh, if you mean you refrained from adding more tests to avoid polluting the diff, don't worry! The more the better (within reason) |
I see, I can reproduce that after all - that should be fixed in ts core, but for now if you wouldn't mind updating the test manually that'd be appreciated Side note, do you use ahlinc's tree-sitter fork for better cli output? It's a bit behind master so generation output is almost not the same, causing CI to fail, use upstream for that or I can force push for you (I had the same experience myself) |
@amaanq thanks for your suggestion! I am running If you can force push for me that will be much appreciated! |
Unfortunately I cannot push to your branch, this is probably because it's under the "ast-grep" org, or because you did not allow repo maintainers to edit your pr, or because the branch name is master (for PRs don't use master/main as it causes issues when checking out) |
Let me change it, thanks! |
fix #231
I updated the test corpus manually since it looks like most of the corpus is not generated by
tree-sitter test -u
.Using update snapshot caused a lot of changes so I didn't do it for better review readability.
I can do a separate PR to update the snapshot by automatic generation.
Checklist: