Skip to content

Commit

Permalink
test: don't use TS_REUSE_ALLOCATOR on Darwin systems
Browse files Browse the repository at this point in the history
For some reason, the linker seems to behave a bit differently with `-exported_symbols_list` on macOS vs other operating systems, so we'll disable this for now
  • Loading branch information
amaanq committed Feb 27, 2024
1 parent 527848d commit eb35502
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 0 additions & 3 deletions cli/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ fn main() {
target_os = "dragonfly",
))]
println!("cargo:rustc-link-arg=-Wl,--dynamic-list=cli/dynamic-symbols.txt");

#[cfg(any(target_os = "macos", target_os = "ios"))]
println!("cargo:rustc-link-arg=-Wl,-exported_symbols_list,cli/dynamic-symbols-darwin.txt");
}

fn web_playground_files_present() -> bool {
Expand Down
1 change: 1 addition & 0 deletions cli/loader/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ impl Loader {

// Always use the same allocator in the CLI as any scanner, useful for debugging and
// tracking memory leaks in tests.
#[cfg(not(any(target_os = "macos", target_os = "ios")))]
command.arg("-DTS_REUSE_ALLOCATOR");

let output = command.output().with_context(|| {
Expand Down

0 comments on commit eb35502

Please sign in to comment.