Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky failure in two javascript tests #112

Closed
gnprice opened this issue Oct 31, 2017 · 1 comment
Closed

Flaky failure in two javascript tests #112

gnprice opened this issue Oct 31, 2017 · 1 comment

Comments

@gnprice
Copy link
Contributor

gnprice commented Oct 31, 2017

I ran across this by chance on a script/test run. Glad the test script prints out its random seed!

$ script/test -s 1509425801
make: Nothing to be done for 'tests'.
Random seed: 1509425801
Executed 32654 tests. 32653 succeeded. 2 failed.
There were failures!

the javascript language parses one invalid subtree right after the viable prefix: repairing an insertion of "eydcelnt(]{" at 31:
Found changed scope outside of any invalidated range;
Position: {2, 26}
Byte index: 52
Line:   x = function(a) { b; } function(c) { d; }
                                ^
Old scopes: (vector: program, if_statement, statement_block, expression_statement, ERROR, function, function, 'u')
New scopes: (vector: program, if_statement, statement_block, expression_statement, assignment_expression, function, function, 'u')
Invalidated ranges:
  {{2, 5}, {2, 25}}


the javascript language parses one invalid subtree right after the viable prefix: repairing an insertion of "eydcelnt(]{" at 31:
test/integration/real_grammars.cc:47: Expected: of length 0
Actual: [ 339 ]


Test run complete. 32654 tests run. 32653 succeeded. 2 failed.

real	0m21.685s
user	0m21.152s
sys	0m0.300s
@maxbrunsfeld
Copy link
Contributor

I think the cause of these failures was fixed in 1e04489. I'm not 100% sure, but I'm going to close this out because these tests no longer exist in their current form; I had to change them because of some big change to the error recovery algorithm.

BekaValentine pushed a commit that referenced this issue Feb 23, 2021
* Arg in arrow function can be a reserved keyword

* Fix alias for reserved_expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants