-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: Rename query to highlighting #1305
Comments
Correct. |
May be it would be better to add some text explaining what to expect from correct provided queries than rename it to the highlighting. An observable highlighting, as I understand, is just a good demonstration of correct queries applied to some text but it's not equal in behavior to the |
I think it is? It needs the Another improvement would be, to set an example highlight query on load. |
Query makes sense to me. The |
same, I think query makes sense, and we should add more information on usage instead of renaming it. For nvim-treesitter we added this help text |
A button or link so you can call up small recorded examples in 2 or 3 langs would be a help. Can't remember now if the playground first comes up with an example but if so, it was lost as soon as I tried my own. One should be exactly the example in the query section of the docs, so it's clear it's THAT 'query', and one that isn't, to show query expressions are specific to each lang grammar. |
I'm definitely open to adding some more explanatory text to the playground. I do think that we should keep using the term "query", because that's the name of this feature of Tree-sitter. Highlighting is related, but it's not the only use for queries. |
The minimal UI of the Playground could benefit from some documentation to make it easier for the newer users to understand what's going on. Also added a link to the new documentation from the local playground. Closes #1305
I think query is too confusing, just had to check the code to find out what it does. I think something like
highlighting
might be a bit better.Is that something, that would be accepted?
The text was updated successfully, but these errors were encountered: