-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node.js prebuilds to language grammars #3073
Comments
I tried that for tree-sitter-cli in ObserverOfTime@d1eace2 but the package would be too large. |
I meant using prebuild/prebuild-install, like already used in node-tree-sitter. This won't make the package larger as it downloads prebuilds from a GitHub release. |
Continuing on from #3106 (comment), if we want to use prebuildify instead of prebuild.
|
Anyhow, this is an example of adding prebuild: segevfiner/tree-sitter-hello@main...prebuild Let me know which one you want to turn into a PR. And whether you want to do something about what I wrote above. e.g. To let users know where the shared workflows are. |
The workflows are still subject to change but a reference in the docs would be nice to have.
I will update the package-npm workflow accordingly.
prebuildify is definitely the better option. |
Problem
Having prebuilds is useful as you then don't have to have a compiler to use them, and can use the prebuilds to generate distributions for different operating systems without having to do so on each target operating system due to having to compile binaries.
This can be done by providing a GitHub Actions workflow, possibly generated by the cli
generate
command and appropriate config/scripts to be included in the package.json.This will be easier if we migrate to napi as then we will only really need one binary per OS/arch combination rather than also for each major version of Node.js.
Expected behavior
For language grammar for Node to have prebuilds.
The text was updated successfully, but these errors were encountered: